#3053 Fix by using custom bool parsing that if a string is found then… by simonsabin · Pull Request #3054 · Azure/data-api-builder

simonsabin · 2026-01-13T22:47:19Z

… it uses the environment replacement and looks for a true false 1 or 0.

Why make this change?

Boolean values can't be set using environment variables. This allows that

What is this change?

Using custom JsonConverter for bools that if a string is detected it uses the string serialiser that uses the environment replacement rules.

How was this tested?

Integration Tests
Unit Tests

… then it uses the environment replacement and looks for a true false 1 or 0.

Copilot

Pull request overview

This pull request fixes issue #3053 by enabling boolean configuration values to be set using environment variables. Previously, boolean values could not use environment variable substitution like string values could.

Changes:

Added a custom BoolJsonConverter that handles boolean deserialization from both native JSON boolean tokens and string tokens (which enables environment variable substitution)
Registered the new converter in the JSON serialization pipeline
Added unit tests to validate boolean values can be set through environment variables

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
src/Config/Converters/BooleanJsonConverterFactory.cs	New custom JSON converter that deserializes boolean values from both JSON booleans and strings, enabling environment variable substitution
src/Config/RuntimeConfigLoader.cs	Registers the BoolJsonConverter in the serialization options
src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserializerTests.cs	Adds test coverage for boolean environment variable replacement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserializerTests.cs

src/Config/Converters/BooleanJsonConverter.cs

src/Config/Converters/BooleanJsonConverterFactory.cs

src/Config/Converters/BooleanJsonConverter.cs

src/Config/Converters/BooleanJsonConverterFactory.cs

…rTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…rTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserializerTests.cs

Aniruddh25

Additional testing for double quoted value boolean value to test the string deserialization.

simonsabin · 2026-01-14T01:08:17Z

Additional testing for double quoted value boolean value to test the string deserialization.

I think this is now catered for it you mean where the json is the following.

{
 .... 
  "enabled": "true"
  ...
}

and also

{
 .... 
   "enabled": true
  ...
}

JerryNixon · 2026-01-14T17:45:17Z

I am not sure this resolves JSON Schema constraints/editing errors, does it?

simonsabin · 2026-01-14T19:49:39Z

I am not sure this resolves JSON Schema constraints/editing errors, does it?

@JerryNixon It doesn't but I've just pushed change to the schema that would.

If thats an acceptable approach I can apply to other booleans.

Interestinlythere does seem to be a mix of json schema validation jsonconverter validation. The jsonconverter stuff looks overly complicated. for some simple serialisation.

…a-api-builder into 3053BooleanEnvSub

souvikghosh04 · 2026-01-21T04:53:00Z

/azp run

azure-pipelines · 2026-01-21T04:53:28Z

Azure Pipelines successfully started running 6 pipeline(s).

souvikghosh04

Approved with suggestions.

src/Config/Converters/BooleanJsonConverter.cs

RubenCerna2079 · 2026-01-21T20:07:55Z

/azp run

azure-pipelines · 2026-01-21T20:08:27Z

Azure Pipelines successfully started running 6 pipeline(s).

souvikghosh04

some tests are failing which is blocking the merge. please ensure to run and validate the tests locally. for example- ..\CosmosTests\SchemaGeneratorTest.cs has multiple failing tests.

src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserializerTests.cs

…on files being CRLF line endings.

simonsabin · 2026-01-23T10:51:50Z

Tests were failing due to inconsistencies with CR and LF endings.
It appears that schemas are generted with CRLFs. The code formatting is enforcing LFs in git.
This makes the results slightly undeterminstic. Had changed the gitattributes to align the .cs files with the code formatting rules, but that breaks as files checked out get LF line endings which breaks the test.

souvikghosh04 · 2026-01-23T16:17:51Z

/azp run

azure-pipelines · 2026-01-23T16:18:19Z

Azure Pipelines successfully started running 6 pipeline(s).

souvikghosh04

Approving latest test fixes

simonsabin · 2026-01-26T15:52:49Z

Are these test failues transient?

#3054) … it uses the environment replacement and looks for a true false 1 or 0. ## Why make this change? Fixes #3053 Boolean values can't be set using environment variables. This allows that ## What is this change? Using custom JsonConverter for bools that if a string is detected it uses the string serialiser that uses the environment replacement rules. ## How was this tested? - [ ] Integration Tests - [x] Unit Tests --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jerry Nixon <1749983+JerryNixon@users.noreply.github.com> Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>

…w boolean properties to be set by env vars (#3092) ## Why make this change? - Server level description is an important field in MCP configuration. This should be included in release 1.7. - Fix to allow boolean properties to be set by environment variables is a requested change. ## What is this change? - Cherry picks #3016 and - #3054 ## How was this tested? PR Pipeline validation. --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: anushakolan <45540936+anushakolan@users.noreply.github.com> Co-authored-by: Anusha Kolan <anushakolan10@gmail.com> Co-authored-by: Simon Sabin <1209963+simonsabin@users.noreply.github.com>

Azure#3053 Fix by using custom bool parsing that if a string is found…

add53ed

… then it uses the environment replacement and looks for a true false 1 or 0.

Copilot AI review requested due to automatic review settings January 13, 2026 22:47

simonsabin requested review from Alekhya-Polavarapu, Aniruddh25, RubenCerna2079, aaronburtle, anushakolan, neeraj-sharma2592, rusamant, sourabh1007, souvikghosh04 and vadeveka as code owners January 13, 2026 22:47

Copilot started reviewing on behalf of simonsabin January 13, 2026 22:47 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

simonsabin and others added 4 commits January 13, 2026 23:12

Update src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserialize…

05b3586

…rTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Config/Converters/BooleanJsonConverterFactory.cs

0b6e7f3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Config/Converters/BooleanJsonConverterFactory.cs

c1759af

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserialize…

36621c6

…rTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Aniruddh25 reviewed Jan 13, 2026

View reviewed changes

src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserializerTests.cs Show resolved Hide resolved

Aniruddh25 requested changes Jan 13, 2026

View reviewed changes

simonsabin added 2 commits January 14, 2026 01:00

Extra handling of numeric values and test coverage

76b0c41

rename file to match class

5c7f38a

simonsabin requested a review from Aniruddh25 January 14, 2026 01:10

Add schema solution

7532d68

This comment was marked as outdated.

Sign in to view

simonsabin and others added 2 commits January 14, 2026 19:59

Merge branch 'main' into 3053BooleanEnvSub

bcf15b2

Add test to validate the pattern matching for string booleans

e3eee4a

simonsabin and others added 3 commits January 17, 2026 15:13

remove suprurious file

097cb86

Merge branch '3053BooleanEnvSub' of https://github.com/simonsabin/dat…

71a0667

…a-api-builder into 3053BooleanEnvSub

Merge branch 'main' into 3053BooleanEnvSub

3dbcd26

souvikghosh04 requested changes Jan 21, 2026

View reviewed changes

src/Config/Converters/BooleanJsonConverter.cs Outdated Show resolved Hide resolved

fix error message for invalid numeric value

a911a92

JerryNixon requested a review from souvikghosh04 January 21, 2026 21:44

souvikghosh04 reviewed Jan 22, 2026

View reviewed changes

src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserializerTests.cs Show resolved Hide resolved

simonsabin added 2 commits January 23, 2026 08:32

fix tests

47a081c

Reverse setting of LF in git attributes as there are tests that rely …

e577a99

…on files being CRLF line endings.

Merge branch 'main' into 3053BooleanEnvSub

8daa63a

souvikghosh04 enabled auto-merge (squash) January 23, 2026 16:45

souvikghosh04 approved these changes Jan 23, 2026

View reviewed changes

souvikghosh04 added this to the Jan 2026 milestone Jan 23, 2026

souvikghosh04 added this to Data API builder Jan 23, 2026

github-project-automation bot moved this to Todo in Data API builder Jan 23, 2026

souvikghosh04 moved this from Todo to Review In Progress in Data API builder Jan 23, 2026

souvikghosh04 merged commit 9025bb3 into Azure:main Jan 27, 2026
11 checks passed

github-project-automation bot moved this from Review In Progress to Done in Data API builder Jan 27, 2026

simonsabin deleted the 3053BooleanEnvSub branch January 27, 2026 06:59

Aniruddh25 mentioned this pull request Jan 31, 2026

Cherry picking server level description to MCP config and fix to allow boolean properties to be set by env vars #3092

Merged

Conversation

simonsabin commented Jan 13, 2026

Why make this change?

What is this change?

How was this tested?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aniruddh25 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simonsabin commented Jan 14, 2026

Uh oh!

JerryNixon commented Jan 14, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

simonsabin commented Jan 14, 2026

Uh oh!

souvikghosh04 commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

souvikghosh04 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RubenCerna2079 commented Jan 21, 2026

Uh oh!

azure-pipelines bot commented Jan 21, 2026

Uh oh!

souvikghosh04 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

simonsabin commented Jan 23, 2026

Uh oh!

souvikghosh04 commented Jan 23, 2026

Uh oh!

azure-pipelines bot commented Jan 23, 2026

Uh oh!

souvikghosh04 left a comment

Choose a reason for hiding this comment

Uh oh!

simonsabin commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Aniruddh25 left a comment •

edited

Loading